frankgh commented on code in PR #74:
URL: https://github.com/apache/cassandra-sidecar/pull/74#discussion_r1408094777
##########
src/main/java/org/apache/cassandra/sidecar/cluster/CassandraAdapterDelegate.java:
##########
@@ -196,7 +217,6 @@ private void healthCheckInternal()
// Unregister the host listener and nullify the session in order
to get a new object.
markAsDownAndMaybeNotify();
maybeUnregisterHostListener(activeSession);
- cqlSessionProvider.close();
Review Comment:
this removal is correct. The session is now shared across all the instances
managed by sidecar, so closing here is not desired. The lifecycle of the
session is managed by the application, so on application shutdown it should
close the session
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
