JeetKunDoug commented on code in PR #74:
URL: https://github.com/apache/cassandra-sidecar/pull/74#discussion_r1408247374
##########
adapters/base/src/main/java/org/apache/cassandra/sidecar/adapters/base/CassandraFactory.java:
##########
@@ -43,13 +45,16 @@ public CassandraFactory(DnsResolver dnsResolver, String
sidecarVersion)
/**
* Returns a new adapter for Cassandra 4.0 clusters.
*
- * @param session the session to the Cassandra database
- * @param jmxClient the JMX client to connect to the Cassandra database
+ * @param session the session to the Cassandra database
+ * @param jmxClient the JMX client to connect to the
Cassandra database
+ * @param localNativeTransportAddress the address and port on which this
instance is configured to listen
Review Comment:
@frankgh keeps making me do this - if we can pick one style or the other
and stick to it I'm happy to not align or align - I tend to agree w/ @yifan-c
here but don't have a strong opinion one way or another. Git/GitHub are smart
enough to be able to highlight that it's just a whitespace change when you do
make those kinds of alignment changes, so I don't think it's a huge deal, but I
also get the "fewer changes in a commit is good" vibe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
