JeetKunDoug commented on code in PR #74:
URL: https://github.com/apache/cassandra-sidecar/pull/74#discussion_r1379295886
##########
src/test/integration/org/apache/cassandra/sidecar/testing/IntegrationTestBase.java:
##########
@@ -114,6 +132,34 @@ void setup(AbstractCassandraTestContext
cassandraTestContext) throws Interrupted
context.awaitCompletion(5, TimeUnit.SECONDS);
}
+ /**
+ * Some tests may want to "manage" fewer instances than the complete
cluster.
+ * Therefore, override this if your test wants to manage fewer than the
complete cluster size.
+ * The Sidecar will be configured to manage the first N instances in the
cluster by instance number.
+ * Defaults to the entire cluster.
+ *
+ * @param clusterSize the size of the cluster as defined by the
integration test
+ * @return the number of instances to manage
+ */
+ protected int getNumInstancesToManage(int clusterSize)
+ {
+ return clusterSize;
+ }
+
+ protected InstancesConfig getInstancesConfig()
+ {
+ return injector.getInstance(InstancesConfig.class);
+ }
+
+ private void scheduleHealthCheck(long intervalMillis)
Review Comment:
Yeah - likely - I'll rebase once I make the other changes and see how it
behaves without the health check here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
