JeetKunDoug commented on code in PR #74:
URL: https://github.com/apache/cassandra-sidecar/pull/74#discussion_r1379283377
##########
src/test/integration/org/apache/cassandra/sidecar/testing/IntegrationTestBase.java:
##########
@@ -103,7 +117,11 @@ void setup(AbstractCassandraTestContext
cassandraTestContext) throws Interrupted
server.start()
.onSuccess(s -> {
+ // TODO: DTR - Do we still need the new scheduleHealthCheck
here (and the sleep below)?
+ scheduleHealthCheck(5000); // Check health frequently so
adapters are created in time for tests
sidecarTestContext.registerInstanceConfigListener(this::healthCheck);
+ // Give everything a moment to get started and connected
+ Uninterruptibles.sleepUninterruptibly(1, TimeUnit.SECONDS);
if (!sidecarTestContext.isClusterBuilt())
{
context.completeNow();
Review Comment:
Happy to make this change - please tell me why so I can document it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]