mike-tr-adamson commented on code in PR #2989: URL: https://github.com/apache/cassandra/pull/2989#discussion_r1430148490
########## src/java/org/apache/cassandra/index/sai/disk/v1/trie/LiteralIndexWriter.java: ########## @@ -40,72 +40,59 @@ * Builds an on-disk inverted index structure: terms dictionary and postings lists. */ @NotThreadSafe -public class LiteralIndexWriter implements Closeable +public class LiteralIndexWriter implements SegmentWriter Review Comment: Remove `Closeable` and make the `LiteralIndexWriter` operate similarly to the `NumericIndexWriter`. The writers are now opened and closed in the `writeCompleteSegment` method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
