mike-tr-adamson commented on code in PR #2989:
URL: https://github.com/apache/cassandra/pull/2989#discussion_r1430458459
##########
src/java/org/apache/cassandra/index/sai/disk/v1/segment/SegmentRamBuffer.java:
##########
@@ -73,9 +73,9 @@ public long add(int segmentRowId, byte[] value)
return (trie.sizeOnHeap() - initialSizeOnHeap) +
(postingsAccumulator.heapAllocations() - reducerHeapSize);
}
- public BlockBalancedTreeIterator iterator()
+ public SegmentRamIterator iterator()
{
- return
BlockBalancedTreeIterator.fromTrieIterator(trie.entrySet().iterator(),
bytesPerValue);
+ return SegmentRamIterator.fromTrieIterator(trie.entrySet().iterator());
Review Comment:
I agree that the `Pair` usage has got out of hand with the SAI code, so we
can start by getting rid of it here.
I will have a look at the iterator transformations as well. This has been
through a number of iterations during this ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
