maedhroz commented on code in PR #2989:
URL: https://github.com/apache/cassandra/pull/2989#discussion_r1430365585
##########
src/java/org/apache/cassandra/index/sai/disk/v1/segment/SegmentRamBuffer.java:
##########
@@ -15,34 +15,34 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.cassandra.index.sai.disk.v1.bbtree;
+package org.apache.cassandra.index.sai.disk.v1.segment;
import java.util.concurrent.atomic.LongAdder;
import javax.annotation.concurrent.NotThreadSafe;
import org.apache.cassandra.db.memtable.TrieMemtable;
import org.apache.cassandra.db.tries.InMemoryTrie;
import org.apache.cassandra.utils.Throwables;
-import org.apache.cassandra.utils.bytecomparable.ByteSource;
+import org.apache.cassandra.utils.bytecomparable.ByteComparable;
import org.apache.lucene.util.packed.PackedInts;
import org.apache.lucene.util.packed.PackedLongValues;
/**
- * On-heap buffer for values that provides a sorted view of itself as a {@link
BlockBalancedTreeIterator}.
+ * On-heap buffer for values that provides a sorted view of itself as a {@link
SegmentRamIterator}.
*/
@NotThreadSafe
-public class BlockBalancedTreeRamBuffer
+public class SegmentRamBuffer
Review Comment:
```suggestion
public class TrieSegmentBuffer
```
We might as well use "trie" to be a little more descriptive. The trie is
essential rather than accidental.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
