maedhroz commented on code in PR #2989:
URL: https://github.com/apache/cassandra/pull/2989#discussion_r1430357387
##########
src/java/org/apache/cassandra/index/sai/disk/v1/bbtree/BlockBalancedTreeWriter.java:
##########
@@ -488,6 +491,7 @@ private class LeafWriter
private final Callback callback;
private final ByteBuffersDataOutput leafOrderIndexOutput = new
ByteBuffersDataOutput(2 * 1024);
private final ByteBuffersDataOutput leafBlockOutput = new
ByteBuffersDataOutput(32 * 1024);
+ private final byte[] packedValue = new byte[bytesPerValue];
Review Comment:
This is basically the old scratch buffer, right?
The only minor thing is that `writeCommonPrefix()` and `valueInBounds()`
also use the name `packedValue`, so perhaps we could rename this to avoid
possible confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
