dcapwell commented on code in PR #84:
URL: https://github.com/apache/cassandra-accord/pull/84#discussion_r1544914740
##########
accord-core/src/main/java/accord/coordinate/FetchMaxConflict.java:
##########
@@ -85,7 +85,7 @@ public static AsyncResult<Timestamp> fetchMaxConflict(Node
node, Seekables<?, ?>
@Override
void contact(Set<Node.Id> nodes, Topologies topologies,
Callback<GetMaxConflictOk> callback)
{
- node.send(nodes, to -> new GetMaxConflict(to, topologies, route,
keysOrRanges, executionEpoch));
+ node.send(nodes, to -> new GetMaxConflict(to, topologies, route,
keysOrRanges, executionEpoch), callback);
Review Comment:
the fact this happened implies that burn test doesn't hit this code path, so
should be something we think about adding... C* hits this all the time as we
don't have a max applied, so we would block forever
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
