dcapwell commented on code in PR #84:
URL: https://github.com/apache/cassandra-accord/pull/84#discussion_r1544916723
##########
accord-core/src/main/java/accord/topology/TopologyManager.java:
##########
@@ -587,7 +590,9 @@ public Topologies preciseEpochs(Unseekables<?> select, long
minEpoch, long maxEp
{
Epochs snapshot = epochs;
- TopologyMismatch tm =
TopologyMismatch.checkForMismatch(snapshot.get(maxEpoch).global(), select);
+ EpochState maxState = snapshot.get(maxEpoch);
+ Invariants.checkState(maxState != null, "Unable to find epoch %d;
known epochs are %d -> %d", maxEpoch, snapshot.minEpoch(),
snapshot.currentEpoch);
Review Comment:
in C* we bootstrap with epoch=9 but there are pending txn in epoch=8... this
means that we are failing to handle those txn and SimpleProgressLog starts
spamming us... I tried to look at how to add historic epochs but it was getting
a bit annoying and didn't actually impact the bootstrap tests... so figured I
could delay that problem to another patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
