dcapwell commented on code in PR #84:
URL: https://github.com/apache/cassandra-accord/pull/84#discussion_r1544915771
##########
accord-core/src/main/java/accord/impl/AbstractFetchCoordinator.java:
##########
@@ -231,16 +234,37 @@ void abort(Ranges abort)
// TODO (expected): implement abort
}
- public static class FetchRequest extends WaitUntilAppliedAndReadData
+ public static class FetchRequest extends ReadData
{
+ private static final ExecuteOn EXECUTE_ON = new ExecuteOn(Applied,
Applied);
+ public final PartialTxn read;
Review Comment:
honestly I kept this `PartialTxn` because it didn't impact anything and I
needed to get green before really thinking about it... We only actually care
about `accord.api.Read` so would be a trivial refactor to switch to that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]