dcapwell commented on code in PR #84:
URL: https://github.com/apache/cassandra-accord/pull/84#discussion_r1544917667
##########
accord-core/src/test/java/accord/impl/list/ListRead.java:
##########
@@ -78,13 +78,17 @@ public AsyncChain<Data> read(Seekable key, SafeCommandStore
safeStore, Timestamp
{
default: throw new AssertionError();
case Key:
+ if (!keys.contains((Key)key))
Review Comment:
the main reason bootstrap regression failed to be detected in burn test was
that it switched to using the sync point's emptyTxn, which has 0 keys... since
ListRead supports ranges it was able to return the data requested from
bootstrap even though its inputs were outside of the range of `keys`... This
check helps protect that from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
