michaelsembwever commented on code in PR #3168:
URL: https://github.com/apache/cassandra/pull/3168#discussion_r1548238450
##########
src/java/org/apache/cassandra/schema/TableParams.java:
##########
@@ -490,6 +490,11 @@ public Builder extensions(Map<String, ByteBuffer> val)
public static class Serializer implements MetadataSerializer<TableParams>
{
+ private final String keyspace;
Review Comment:
we're pulling in `keyspace` from the context when we shouldn't be (the call
to `CompressionParams.defaultParams(keyspace)` needs to be kept in the context).
i'm not sure yet how to do this…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
