smiklosovic commented on code in PR #3168:
URL: https://github.com/apache/cassandra/pull/3168#discussion_r1549301292
##########
src/java/org/apache/cassandra/schema/TableParams.java:
##########
@@ -490,6 +490,11 @@ public Builder extensions(Map<String, ByteBuffer> val)
public static class Serializer implements MetadataSerializer<TableParams>
{
+ private final String keyspace;
Review Comment:
@Claudenw @michaelsembwever
I tried to fix it here https://github.com/Claudenw/cassandra/pull/12/files
It moved a lot of changes back. They are not necessary at all. Just because
we expected keyspace in build method as a param made them more verbose than
necessary.
I think it is also not necessary to call it every time, if one reads the
context where that code is used, sometimes it is not necessary to deal with
compression params again etc ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
