Claudenw commented on code in PR #3168:
URL: https://github.com/apache/cassandra/pull/3168#discussion_r1549239480
##########
src/java/org/apache/cassandra/schema/TableParams.java:
##########
@@ -490,6 +490,11 @@ public Builder extensions(Map<String, ByteBuffer> val)
public static class Serializer implements MetadataSerializer<TableParams>
{
+ private final String keyspace;
Review Comment:
If I read the code correctly `TableParams.Serializer.deserialize()` is only
reading something written by `TableParams.Serializer.serialize()`. That means
the compression type was already defined when the data was serialized. So, we
could pass a `null` parameter to the `builder.build()` method and then in the
builder catch a `null` keyspace as meaning "just use the old default" then the
value that was serialized would be used and the "old" default compression
params would be used in any case where the compression was serialized as an
empty map.
Would this work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
