dcapwell commented on code in PR #87:
URL: https://github.com/apache/cassandra-accord/pull/87#discussion_r1591511009
##########
accord-core/src/main/java/accord/local/SerializerSupport.java:
##########
@@ -162,15 +167,15 @@ private static Command.Truncated truncated(Mutable attrs,
SaveStatus status, Tim
case TruncatedApplyWithDeps:
Set<MessageType> witnessed = messageProvider.test(APPLY_TYPES);
checkState(!witnessed.isEmpty());
- if (witnessed.contains(APPLY_MINIMAL_REQ))
+ if (witnessed.contains(APPLY_MAXIMAL_REQ))
Review Comment:
there was a bug where the `partialTxn` exists in `APPLY_MINIMAL_REQ` but
because the next section is an `if` and not an `else if` the
`PROPAGATE_APPLY_MSG` was seen, but that doesn't have the `partialTxn`; this
lead to a NPE...
I changed to use else for each section and go from max -> min -> propagate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
