belliottsmith commented on code in PR #87:
URL: https://github.com/apache/cassandra-accord/pull/87#discussion_r1595398820
##########
accord-core/src/main/java/accord/coordinate/AbstractCoordinatePreAccept.java:
##########
@@ -219,7 +220,7 @@ final void onNewEpoch(Topologies prevTopologies, long
latestEpoch)
onNewEpochTopologyMismatch(mismatch);
return;
}
- topologies = node.topology().withUnsyncedEpochs(route,
txnId.epoch(), latestEpoch);
+ topologies = node.topology().withUnsyncedEpochs(route, txnId ==
null ? executeAtEpoch() : txnId.epoch(), latestEpoch);
Review Comment:
Perhaps introduce a helper method `earliestEpoch` or something (that could
in theory be overridden) so this semantic is clearer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
