dcapwell commented on code in PR #87:
URL: https://github.com/apache/cassandra-accord/pull/87#discussion_r1596065756
##########
accord-core/src/main/java/accord/local/SerializerSupport.java:
##########
@@ -285,14 +308,25 @@ else if (witnessed.contains(STABLE_FAST_PATH_REQ))
else
{
checkState(witnessed.contains(STABLE_SLOW_PATH_REQ),
"Unable to find STABLE_SLOW_PATH_REQ; witnessed %s", new
LoggedMessageProvider(messageProvider));
- if (witnessed.contains(COMMIT_SLOW_PATH_REQ))
+ if (witnessed.contains(COMMIT_MAXIMAL_REQ))
+ {
+ commit = messageProvider.commitMaximal();
+ }
+ else if (witnessed.contains(COMMIT_SLOW_PATH_REQ))
{
commit = messageProvider.commitSlowPath();
}
+ else if (witnessed.contains(PRE_ACCEPT_REQ) ||
witnessed.contains(BEGIN_RECOVER_REQ) ||
witnessed.contains(PROPAGATE_PRE_ACCEPT_MSG))
+ {
+ Commit slowPath = messageProvider.stableSlowPath();
Review Comment:
That change hits NPE in `BurnTest`. 4/4 tests failed this way
```
java.lang.NullPointerException
at
accord.local.SerializerSupport.extract(SerializerSupport.java:323)
at
accord.local.SerializerSupport.committed(SerializerSupport.java:151)
at
accord.local.SerializerSupport.reconstruct(SerializerSupport.java:111)
```
this is due to `slowPath` not being present. The test journal returns
`null`, not sure what `AccordJournal` does when you ask for something not
found... can always make it explicit `null` isn't allowed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
