belliottsmith commented on code in PR #87:
URL: https://github.com/apache/cassandra-accord/pull/87#discussion_r1595403889
##########
accord-core/src/main/java/accord/local/Bootstrap.java:
##########
@@ -261,7 +261,11 @@ private void safeToReadCallback(SafeToRead state,
Timestamp executeAt, Throwable
else
{
// TODO (expected): first check to see if we are still relevant
- node.agent().onFailedBootstrap("SafeToRead", state.ranges, ()
-> started(state, null), failure);
+ CommandStore store = CommandStore.current();
+ node.agent().onFailedBootstrap("SafeToRead", state.ranges, ()
-> {
+ if (CommandStore.maybeCurrent() == store) started(state,
null);
Review Comment:
maybe we should have a method on `CommandStore` that accepts a `self`
parameter and either executes the `Runnable` or `submits` it as necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]