belliottsmith commented on code in PR #87:
URL: https://github.com/apache/cassandra-accord/pull/87#discussion_r1598317652
##########
accord-core/src/main/java/accord/local/Command.java:
##########
@@ -963,7 +970,7 @@ public boolean isEqualOrFuller(Command command)
public static class PreAccepted extends AbstractCommand
{
- private final Timestamp executeAt;
+ private final @Nullable Timestamp executeAt;
Review Comment:
I don't think this should ever be null? If we're `AcceptedInvalidated` (or,
logically, `PreAcceptedInvalidated` that doesn't currently exist as a reified
state but is a side-state of `NotDefined`) then we shouldn't be a `PreAccepted`
object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
