dcapwell commented on code in PR #101:
URL: https://github.com/apache/cassandra-accord/pull/101#discussion_r1664570569
##########
accord-core/src/main/java/accord/coordinate/Exhausted.java:
##########
@@ -37,4 +39,16 @@ public Exhausted(TxnId txnId, @Nullable RoutingKey homeKey,
String message)
{
super(txnId, homeKey, message);
}
+
+ protected Exhausted(TxnId txnId, @Nullable RoutingKey homeKey, Exhausted
cause)
+ {
+ super(txnId, homeKey, cause);
+ }
+
+ @Override
+ public Exhausted wrap()
Review Comment:
not a fan of this pattern as its hard to maintain... you *must* extend, but
the base type also defines, so adding a new type will fail eventually when
`wrap` is called... I don't personally see the benefit of keeping the type as
it just makes things more confusing to me... `ExecutionException` is a good
type as its clear the `cause` is what you want, but also keeps the stack trace
of the call... but when we have the main error as the top level type, it can be
confusing what happened
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
