aweisberg commented on code in PR #101:
URL: https://github.com/apache/cassandra-accord/pull/101#discussion_r1664596260
##########
accord-core/src/main/java/accord/coordinate/Exhausted.java:
##########
@@ -37,4 +39,16 @@ public Exhausted(TxnId txnId, @Nullable RoutingKey homeKey,
String message)
{
super(txnId, homeKey, message);
}
+
+ protected Exhausted(TxnId txnId, @Nullable RoutingKey homeKey, Exhausted
cause)
+ {
+ super(txnId, homeKey, cause);
+ }
+
+ @Override
+ public Exhausted wrap()
Review Comment:
I can have this generate an illegal state exception if you try to wrap and
it changes the type. Alternatively I can restructure hierarchy so there is no
default implementation and then it's statically enforced.
The problem with changing the type is that then you have catch blocks that
don't work because they don't go through the entire causal chain. That is what
originally sent me down this rabbit hole.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
