dcapwell commented on code in PR #101:
URL: https://github.com/apache/cassandra-accord/pull/101#discussion_r1664595298
##########
accord-core/src/main/java/accord/topology/TopologyManager.java:
##########
@@ -371,17 +395,86 @@ private int indexOf(long epoch)
}
}
+ private static class FutureEpoch
+ {
+ private volatile AsyncResult.Settable<Void> future;
+ private long deadlineMillis;
+
+ public FutureEpoch(long deadlineMillis)
+ {
+ this.future = AsyncResults.settable();
+ this.deadlineMillis = deadlineMillis;
Review Comment:
> Durability scheduling
as far as I can tell that is the only caller of `unixTime(TimeUnit)` and it
doesn't need `currentTimeMillis` and is better as `nanoTime` (as you are
pointing out)... so moving `unixTime(TimeUnit)` to `elapsedTime` makes sense to
me...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]