dcapwell commented on code in PR #101:
URL: https://github.com/apache/cassandra-accord/pull/101#discussion_r1664580328
##########
accord-core/src/main/java/accord/local/NodeTimeService.java:
##########
@@ -36,18 +37,53 @@ public interface NodeTimeService
long now();
/**
- * Return the current time since the Unix epoch in the specified time
unit. May still be simulated time and not
- * real time.
+ * Return the current time since some arbitrary epoch in the specified
time unit. May still be simulated time and not
+ * real time. The time returned by this will be monotonic.
*/
- long unix(TimeUnit unit);
+ long elapsed(TimeUnit unit);
Review Comment:
I don't think this change is good for the project. We do require `unix` and
not `elapsed` in most places, and `elapsed` is relative to the local node only
and not cross the cluster. This logic is used as part of our `TxnId` so
switching to `elapsed` *should* break us in subtle ways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
