dcapwell commented on code in PR #103:
URL: https://github.com/apache/cassandra-accord/pull/103#discussion_r1674876997
##########
accord-core/src/main/java/accord/local/Node.java:
##########
@@ -241,7 +242,21 @@ public long epoch()
private synchronized EpochReady onTopologyUpdateInternal(Topology
topology, boolean startSync)
{
Supplier<EpochReady> bootstrap = commandStores.updateTopology(this,
topology, startSync);
- return this.topology.onTopologyUpdate(topology, bootstrap);
+ Supplier<EpochReady> ordering = () -> {
Review Comment:
this is one of the two core changes in this PR. By ordering
`EpochReady.coordination`, we have the property that epoch=5 being ready
implies all epochs before are also, this property is required for C* to recover
the known epochs learned *before* joining the ring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
