dcapwell commented on code in PR #103:
URL: https://github.com/apache/cassandra-accord/pull/103#discussion_r1674888745
##########
accord-core/src/main/java/accord/utils/RandomSource.java:
##########
@@ -350,7 +350,7 @@ default long reset()
default Random asJdkRandom()
{
- return new Random()
+ return new Random(nextLong())
Review Comment:
this was a bug that impacted deterministic execution. When we fork to a
java `Random` we didn't control the seed so could have different histories
cross runs with the same seed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
