dcapwell commented on code in PR #103:
URL: https://github.com/apache/cassandra-accord/pull/103#discussion_r1674880769
##########
accord-core/src/main/java/accord/primitives/TxnId.java:
##########
@@ -166,7 +166,7 @@ public static TxnId minForEpoch(long epoch)
return new TxnId(epochMsb(epoch), 0, Id.NONE);
}
- private static final Pattern PARSE =
Pattern.compile("\\[(?<epoch>[0-9]+),(?<hlc>[0-9]+),(?<flags>[0-9]+)\\([KREWNSXL]\\),(?<node>[0-9]+)]");
+ private static final Pattern PARSE =
Pattern.compile("\\[(?<epoch>[0-9]+),(?<hlc>[0-9]+),(?<flags>[0-9]+)\\([KREWNSXL]+\\),(?<node>-?[0-9]+)]");
Review Comment:
bug found in testing. The property `this == parse(this.toString())` was not
valid, and we actually could not parse anything at all! There is a new
property test to make sure this is working and doesn't break again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
