dcapwell commented on code in PR #103:
URL: https://github.com/apache/cassandra-accord/pull/103#discussion_r1674882725
##########
accord-core/src/main/java/accord/topology/Shard.java:
##########
@@ -41,27 +41,34 @@ public class Shard
public final List<Id> nodes;
public final ExtendedSortedArrayList<Id> sortedNodes;
public final Set<Id> fastPathElectorate;
- public final Set<Id> joining;
+ public final Set<Id> joining, leaving;
Review Comment:
in accord we don't leverage this, though it would be nice... we have cases
where we ask nodes that are leaving for information, and then rely on timeouts
to select from another peer. I didn't want to change this behavior in this
patch, but `leaving` is important during C* boot up so it knows which nodes to
mark removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
