dcapwell commented on code in PR #103:
URL: https://github.com/apache/cassandra-accord/pull/103#discussion_r1674894495
##########
accord-core/src/test/java/accord/utils/Property.java:
##########
@@ -454,16 +460,35 @@ public <State, SystemUnderTest> void
check(Commands<State, SystemUnderTest> comm
throw new IllegalArgumentException("Unable
to find next command");
cmd = cmdGen.next(rs);
}
- history.add(cmd.detailed(state));
- Object stateResult = cmd.apply(state);
- cmd.checkPostconditions(state, stateResult,
- sut, cmd.run(sut));
+ if (cmd instanceof MultistepCommand)
Review Comment:
Added for `TopologyMixupTest`. Some times it's nice to produce a command
that actually is multiple commands that run back to back. This is mostly done
to have a more detailed history more than anything else.
I am not a fan of the interface and finds that the sub command `details`
isn't as nice as we compute them *before* running the first command, it would
be nice to defer to right before executing the command...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
