dcapwell commented on code in PR #3432:
URL: https://github.com/apache/cassandra/pull/3432#discussion_r1693355925
##########
src/java/org/apache/cassandra/utils/concurrent/Ref.java:
##########
@@ -99,7 +100,8 @@
public final class Ref<T> implements RefCounted<T>
{
static final Logger logger = LoggerFactory.getLogger(Ref.class);
- public static final boolean DEBUG_ENABLED =
TEST_DEBUG_REF_COUNT.getBoolean();
+ public static final boolean TRACE_ENABLED =
TEST_DEBUG_REF_COUNT.getBoolean();
Review Comment:
can we still back to `DEBUG_ENABLED`? the property is `debug`, and we add
debug details... I don't personally see why we should change to `trace`
instead? you added a `DEBUG_EVENTS_ENABLED` but don't see that requiring us to
rename this property.
##########
test/distributed/org/apache/cassandra/distributed/test/accord/AccordLoadTest.java:
##########
@@ -172,4 +173,13 @@ protected Logger logger()
{
return logger;
}
+
+ public static void main(String[] args) throws Throwable
Review Comment:
why do we need a main method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
