dcapwell commented on code in PR #3432:
URL: https://github.com/apache/cassandra/pull/3432#discussion_r1693486455
##########
src/java/org/apache/cassandra/service/accord/serializers/CommandStoreSerializers.java:
##########
@@ -153,9 +153,9 @@ public RedundantBefore.Entry deserialize(DataInputPlus in,
int version) throws I
long endEpoch = in.readUnsignedVInt();
if (endEpoch == 0) endEpoch = Long.MAX_VALUE;
else endEpoch = startEpoch + 1 + endEpoch;
- TxnId bootstrappedAt = CommandSerializers.txnId.deserialize(in,
version);
TxnId locallyAppliedOrInvalidatedBefore =
CommandSerializers.txnId.deserialize(in, version);
TxnId shardAppliedOrInvalidatedBefore =
CommandSerializers.txnId.deserialize(in, version);
+ TxnId bootstrappedAt = CommandSerializers.txnId.deserialize(in,
version);
Review Comment:
updated the reflective diff to work with arrays and see
```
ReflectionUtils.recursiveEquals(read, input);
diff = {ArrayList@3937} size = 7
0 = {ReflectionUtils$Difference@4754} "Diff{path='.values.[0].endEpoch.',
lhs=195970445814880, rhs=195970445814878}"
1 = {ReflectionUtils$Difference@4755} "Diff{path='.values.[2].endEpoch.',
lhs=228431633815869, rhs=228431633815867}"
2 = {ReflectionUtils$Difference@4756} "Diff{path='.values.[4].endEpoch.',
lhs=278679697445769, rhs=278679697445767}"
3 = {ReflectionUtils$Difference@4757} "Diff{path='.values.[6].endEpoch.',
lhs=274102584243720, rhs=274102584243718}"
4 = {ReflectionUtils$Difference@4758} "Diff{path='.values.[8].endEpoch.',
lhs=263275610724048, rhs=263275610724046}"
5 = {ReflectionUtils$Difference@4759} "Diff{path='.values.[10].endEpoch.',
lhs=201513512660742, rhs=201513512660740}"
6 = {ReflectionUtils$Difference@4760} "Diff{path='.values.[12].endEpoch.',
lhs=277526568649263, rhs=277526568649261}"
```
so for some reason every other entry has the wrong epoch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
