belliottsmith commented on code in PR #3432:
URL: https://github.com/apache/cassandra/pull/3432#discussion_r1693362198
##########
src/java/org/apache/cassandra/service/accord/serializers/CommandStoreSerializers.java:
##########
@@ -153,9 +153,9 @@ public RedundantBefore.Entry deserialize(DataInputPlus in,
int version) throws I
long endEpoch = in.readUnsignedVInt();
if (endEpoch == 0) endEpoch = Long.MAX_VALUE;
else endEpoch = startEpoch + 1 + endEpoch;
- TxnId bootstrappedAt = CommandSerializers.txnId.deserialize(in,
version);
TxnId locallyAppliedOrInvalidatedBefore =
CommandSerializers.txnId.deserialize(in, version);
TxnId shardAppliedOrInvalidatedBefore =
CommandSerializers.txnId.deserialize(in, version);
+ TxnId bootstrappedAt = CommandSerializers.txnId.deserialize(in,
version);
Review Comment:
This was found by new invariants. Happy to add a dedicated test if you think
that would be warranted as well, but will not have time to do a comprehensive
end to end test of serializers to catch this kind of problem (but maybe should
take an action item to do so comprehensively before this is considered prod
ready)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
