belliottsmith commented on code in PR #3432:
URL: https://github.com/apache/cassandra/pull/3432#discussion_r1693363863
##########
src/java/org/apache/cassandra/utils/concurrent/Ref.java:
##########
@@ -99,7 +100,8 @@
public final class Ref<T> implements RefCounted<T>
{
static final Logger logger = LoggerFactory.getLogger(Ref.class);
- public static final boolean DEBUG_ENABLED =
TEST_DEBUG_REF_COUNT.getBoolean();
+ public static final boolean TRACE_ENABLED =
TEST_DEBUG_REF_COUNT.getBoolean();
Review Comment:
It’s just there’s two kinds of debugging now. Don’t feel super strongly
about how we distinguish between them, but wanted to disambiguate and the old
(now trace) logic traces call sites and stack traces, whereas the new permits
you to log arbitrary status updates - this is what allowed me to quickly pin
down the cache reference leak.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
