belliottsmith commented on code in PR #3432:
URL: https://github.com/apache/cassandra/pull/3432#discussion_r1696055743
##########
src/java/org/apache/cassandra/service/accord/async/AsyncOperation.java:
##########
@@ -311,12 +315,28 @@ public void run()
}
}
+ private boolean preRun()
+ {
+ commandStore.checkInStoreThread();
+ try
+ {
+ return runInternal(true);
+ }
+ catch (Throwable t)
+ {
+ logger.error(String.format("Operation %s failed", this), t);
+ fail(t);
+ return false;
Review Comment:
But we return `false` so we won't submit ourselves - and even if we did,
we've set our internal status to FAILED so the `run` method will do nothing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
