dcapwell commented on code in PR #3432:
URL: https://github.com/apache/cassandra/pull/3432#discussion_r1695912720
##########
src/java/org/apache/cassandra/service/accord/async/AsyncOperation.java:
##########
@@ -301,6 +300,13 @@ public void start(BiConsumer<? super R, Throwable>
callback)
{
Invariants.checkState(this.callback == null);
this.callback = callback;
+ if (commandStore.inStore())
Review Comment:
> That said, the load logic is mostly asynchronous, so we'd be talking about
serious logic bugs I think.
this code path has broken in nightly benchmark clusters often... so making
sure we properly handle errors is best...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
