belliottsmith commented on code in PR #3432:
URL: https://github.com/apache/cassandra/pull/3432#discussion_r1693952815
##########
src/java/org/apache/cassandra/service/accord/AccordSafeCommand.java:
##########
@@ -27,9 +27,33 @@
import accord.local.Listeners;
import accord.local.SafeCommand;
import accord.primitives.TxnId;
+import org.apache.cassandra.utils.concurrent.Ref;
public class AccordSafeCommand extends SafeCommand implements
AccordSafeState<TxnId, Command>
{
+ public static class DebugAccordSafeCommand extends AccordSafeCommand
Review Comment:
I think on balance it would probably be helpful to be able to use these for
validation testing with a certain paranoia or debug setting. By itself this
wasn't enough to debug the problem (the Ref changes and peppering log
statements that would be printed by the leaked references was what tracked the
issue down), but it was enough to tell that we had a problem, and that we
needed to do that. I'll add a suitable flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
