dcapwell commented on code in PR #3432:
URL: https://github.com/apache/cassandra/pull/3432#discussion_r1695950094
##########
src/java/org/apache/cassandra/service/accord/async/AsyncOperation.java:
##########
@@ -311,12 +315,28 @@ public void run()
}
}
+ private boolean preRun()
+ {
+ commandStore.checkInStoreThread();
+ try
+ {
+ return runInternal(true);
+ }
+ catch (Throwable t)
+ {
+ logger.error(String.format("Operation %s failed", this), t);
+ fail(t);
+ return false;
Review Comment:
if we fail we will rerun (aka schedule in the background)?
##########
src/java/org/apache/cassandra/service/accord/async/AsyncOperation.java:
##########
@@ -311,12 +315,28 @@ public void run()
}
}
+ private boolean preRun()
+ {
+ commandStore.checkInStoreThread();
+ try
+ {
+ return runInternal(true);
+ }
+ catch (Throwable t)
+ {
+ logger.error(String.format("Operation %s failed", this), t);
Review Comment:
```suggestion
logger.error("Operation {} failed", this, t);
```
Seen the pattern of using `String.format` w/e a throwable is done by many
people, but that isn't required in any of the loggers...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
