aweisberg commented on code in PR #3395:
URL: https://github.com/apache/cassandra/pull/3395#discussion_r1709793691
##########
src/java/org/apache/cassandra/service/BatchlogResponseHandler.java:
##########
@@ -31,6 +31,8 @@ public class BatchlogResponseHandler<T> extends
AbstractWriteResponseHandler<T>
AbstractWriteResponseHandler<T> wrapped;
BatchlogCleanup cleanup;
protected volatile int requiredBeforeFinish;
+ // Defer cleanup until `maybeAckMutationForCleanup` is called
+ private boolean deferCleanup = false;
Review Comment:
I ended up refactoring this to remove `deferCleanup` entirely since
`Cleanup` can be interacted with more directly to account for the actual number
of wrappers that need to be created + 1 ack for the Accord txn.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
