aweisberg commented on code in PR #3395:
URL: https://github.com/apache/cassandra/pull/3395#discussion_r1709802094
##########
src/java/org/apache/cassandra/service/StorageProxy.java:
##########
@@ -1263,53 +1218,22 @@ public static void mutateWithTriggers(List<? extends
IMutation> mutations,
}
}
- Collection<Mutation> augmented =
TriggerExecutor.instance.execute(mutations);
+ List<Mutation> augmented = TriggerExecutor.instance.execute(mutations);
String keyspaceName = mutations.iterator().next().getKeyspaceName();
- boolean updatesView =
Keyspace.open(mutations.iterator().next().getKeyspaceName())
+ boolean updatesView = Keyspace.open(keyspaceName)
.viewManager
.updatesAffectView(mutations, true);
-
+ // TODO (review): This is not the same as augmented? Doesn't seem right
Review Comment:
Changed this to use `augmented` if `augemented` is not null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
