aweisberg commented on code in PR #3395:
URL: https://github.com/apache/cassandra/pull/3395#discussion_r1709800508
##########
src/java/org/apache/cassandra/service/accord/AccordService.java:
##########
@@ -592,12 +715,9 @@ public TopologyManager topology()
}
catch (TimeoutException e)
{
+ // TODO (review): This is j.u.c timeout so maybe this should mark?
Review Comment:
I refactored this so that everything goes through `getTxnResult` and the
path in CAS/serial read that wants `ConsensusAttemptResult` uses a conversion
method on the `TxnResult` returned by `getTxnResult`. I do like having that
extra step just because `TxnResult` is a bit of a wonky class at this point
that works in a very proprietary way depending on what kind of transaction we
are running (transaction statement, range read, key read, CAS update).
The range/key reads are in a commit after this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
