belliottsmith commented on code in PR #113:
URL: https://github.com/apache/cassandra-accord/pull/113#discussion_r1746045072
##########
accord-core/src/main/java/accord/local/Command.java:
##########
@@ -462,11 +392,25 @@ public final int hashCode()
public abstract Route<?> route();
/**
- * The command may have an incomplete route when this is false
+ * We require that this is a FullRoute for all states where
isDefinitionKnown().
+ * In some cases, the home shard will contain an arbitrary slice of the
Route where !isDefinitionKnown(),
+ * i.e. when a non-home shard informs the home shards of a transaction to
ensure forward progress.
+ *
+ * If hasBeen(Committed) this must contain the keys for both txnId.epoch
and executeAt.epoch
+ *
+ * TODO (required): audit uses; do not assume non-null means it is a
complete route for the shard;
+ * preferably introduce two variations so callers can declare whether
they need the full shard's route
+ * or any route will do
*/
- public boolean hasFullRoute()
+ @Override
+ @Nullable
+ public abstract Participants<?> participants();
+
+ public Participants<?> maxContactable()
Review Comment:
There's no such thing as a non-participating home key anymore (unrelated to
this patch). The whole Participants interface might want to be removed, but I
don't really want to tackle that yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
