belliottsmith commented on code in PR #113:
URL: https://github.com/apache/cassandra-accord/pull/113#discussion_r1746053195
##########
accord-core/src/main/java/accord/local/SaveStatus.java:
##########
@@ -91,52 +88,51 @@ public enum SaveStatus
*/
public enum LocalExecution
{
- NotReady(Nothing),
- ReadyToExclude(ExecuteAtOnly),
- WaitingToExecute(Decision),
- ReadyToExecute(Decision),
- // TODO (expected): we seem to be able to await this when we know
there are still local execution dependencies
- // we should only request this when we know the transaction can
execute locally
- WaitingToApply(Apply),
- Applying(Apply),
- Applied(Apply),
- CleaningUp(Nothing);
-
- public final Known requires;
-
- LocalExecution(Known requires)
- {
- this.requires = requires;
- }
-
- public boolean isSatisfiedBy(Known known)
- {
- return requires.isSatisfiedBy(known);
- }
-
- public long fetchEpoch(TxnId txnId, Timestamp timestamp)
- {
- if (timestamp == null || timestamp.equals(Timestamp.NONE))
- return txnId.epoch();
-
- switch (this)
- {
- default: throw new AssertionError("Unexpected status: " +
this);
- case NotReady:
- case ReadyToExclude:
- case ReadyToExecute:
- case WaitingToExecute:
- return txnId.epoch();
-
- case WaitingToApply:
- case Applying:
- case Applied:
- case CleaningUp:
- return timestamp.epoch();
- }
- }
+ /**
+ * Still coordinating a decision
+ */
+ NotReady,
Review Comment:
I'm not sure why this is showing as an addition, as this all existed before.
Maybe I moved it from `Status`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
