smiklosovic commented on code in PR #3564: URL: https://github.com/apache/cassandra/pull/3564#discussion_r1776598594
########## test/data/config/version=5.0.0.yml: ########## @@ -126,7 +126,9 @@ tables_fail_threshold: "java.lang.Integer" trace_type_repair_ttl: "org.apache.cassandra.config.DurationSpec.IntSecondsBound" minimum_replication_factor_warn_threshold: "java.lang.Integer" page_size_warn_threshold: "java.lang.Integer" -role_manager: "java.lang.String" Review Comment: ok but ... this is not true for 5.0.0, right? We just changed something for 5.0.0.yaml. I think 5.0-alpha1 should be just renamed to 5.0.0.yaml and then 5.0.0.yaml copied to 5.1-alpha1 and change what is different for this patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
