smiklosovic commented on code in PR #3564:
URL: https://github.com/apache/cassandra/pull/3564#discussion_r1776592362
##########
src/java/org/apache/cassandra/config/DatabaseDescriptor.java:
##########
@@ -2925,12 +2925,12 @@ public static void setListenOnBroadcastAddress(boolean
listen_on_broadcast_addre
public static IInternodeAuthenticator getInternodeAuthenticator()
{
+ Preconditions.checkNotNull(internodeAuthenticator);
return internodeAuthenticator;
}
public static void setInternodeAuthenticator(IInternodeAuthenticator
internodeAuthenticator)
{
- Preconditions.checkNotNull(internodeAuthenticator);
Review Comment:
I dont understand this change. We do want to set something which is indeed
non-null, no? Checking it on `get` is rather strange.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
