michaelsembwever commented on code in PR #3564: URL: https://github.com/apache/cassandra/pull/3564#discussion_r1776795795
########## test/data/config/version=5.0.0.yml: ########## @@ -126,7 +126,9 @@ tables_fail_threshold: "java.lang.Integer" trace_type_repair_ttl: "org.apache.cassandra.config.DurationSpec.IntSecondsBound" minimum_replication_factor_warn_threshold: "java.lang.Integer" page_size_warn_threshold: "java.lang.Integer" -role_manager: "java.lang.String" Review Comment: let's put this in 5.0.x IIUC there's no compatibility break here. it's a (small) internal operational improvement, that's permitted in patch releases. is it possible to keep the 5.0 yaml unchanged, and introduce the new in trunk ? this would be in spirit of no visible user-facing change. we have existing compatibility in place for this type of string→parameterised class change. IMO let's keep this PR focused on the 5.0.x patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
