tiagomlalves commented on code in PR #3564: URL: https://github.com/apache/cassandra/pull/3564#discussion_r1776706501
########## test/data/config/version=5.0.0.yml: ########## @@ -126,7 +126,9 @@ tables_fail_threshold: "java.lang.Integer" trace_type_repair_ttl: "org.apache.cassandra.config.DurationSpec.IntSecondsBound" minimum_replication_factor_warn_threshold: "java.lang.Integer" page_size_warn_threshold: "java.lang.Integer" -role_manager: "java.lang.String" Review Comment: You're right - this is not true because we have changed it for `5.0.0`. My hope was to have this change available in C* 5.0 and not in 5.1 as this is a small improvement. Would it be acceptable, to leave `version=5.0-alpha1.yml` unchanged and create a new `version=5.0.0.yml` with these new changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
