smiklosovic commented on code in PR #3752:
URL: https://github.com/apache/cassandra/pull/3752#discussion_r1890782480
##########
src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java:
##########
@@ -45,6 +45,21 @@ public class ListSnapshots extends NodeToolCmd
description = "Include ephememeral snapshots")
private boolean includeEphemeral = false;
+ @Option(title = "keyspace",
+ name = { "-k", "--keyspace" },
+ description = "Include snapshots of specified keyspace name")
+ private String keyspace = null;
+
+ @Option(title = "table",
+ name = { "-t", "--table" },
+ description = "Include snapshots of specified table name")
+ private String table = null;
+
+ @Option(title = "snapshot",
+ name = { "-n", "--snapshot"},
+ description = "Include snapshots of specified name")
+ private String snapshotName = null;
Review Comment:
A cautious reader sees that there is no logic related to filtering on the
server side in this PR. This is because these changes are already there, we
just do not exercise that functionality yet.
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/snapshot/ListSnapshotsTask.java#L64-L76
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
