absurdfarce commented on PR #2000: URL: https://github.com/apache/cassandra-java-driver/pull/2000#issuecomment-2573513609
Something about this seems... wrong to me. I can't quite put my finger on it yet, but this feels like a fix for this specific situation rather than something we'd want to do generally. Wouldn't I normally expect that "mvn verify" or "mvn package" (or anything that has to actually do a package op generally) would clean out whatever classes might happen to be around and start fresh? It feels like what we actually want here is some way to tell "mvn verify" that hey, it's okay to use whatever class files you find... you don't need to start from scratch. Maybe make the clean operation conditional on some Maven property and include that prop in the build? Furthermore... don't we wind up with a Guava shaded artifact in the local Maven cache after "mvn install" completes? If that's the case why is "mvn verify" trying to compile _anything_... why isn't it just using what's in the cache? Something still seems wrong here.... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
