absurdfarce commented on PR #2000: URL: https://github.com/apache/cassandra-java-driver/pull/2000#issuecomment-2593522972
After pondering this a bit more I think I'm okay with this as a solution to the immediate problem. At the end of the day we'll have a problem if we don't keep the Java8 compiled class files around. If we want to test with other JVMs we'll need to be able to switch to those JVMs and we can't have recompilation in that case. Actually... wait... why is that true? If we switch to a Java11 JDK why aren't we building Java8-compatible class files anyway? We... specify that we want the [target version produced by the compiler](https://github.com/apache/cassandra-java-driver/blob/4.x/pom.xml#L608) to be 1.8... so how are we winding up with version 55 code _at all_? I'm still gonna approve this because I agree we have a much clearer understanding of the mechanism now but it still feels like something is missing here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
