lukasz-antoniak commented on PR #2000: URL: https://github.com/apache/cassandra-java-driver/pull/2000#issuecomment-2574508109
> Wouldn't I normally expect that "mvn verify" or "mvn package" (or anything that has to actually do a package op generally) would clean out whatever classes might happen to be around and start fresh? Maven will check if any of source files has changed, and if not will not attempt to recompile. That is a standard behaviour. To explicitly "start from beginning" you would need to add `clean` option. Driver requires a compilation with JDK 1.8, so this version is configured during `mvn clean install`. Then we switch JDK to newer one to run integration tests. Compiled classes are left untouched, generated by JDK 1.8. > Furthermore... don't we wind up with a Guava shaded artifact in the local Maven cache after "mvn install" completes? If that's the case why is "mvn verify" trying to compile anything... why isn't it just using what's in the cache? The JAR in local cache is present, but this module is a project module, so Maven needs to try to compile it. The whole issue here is that we always asked it to clean compiled classes and recompile sources again. If we apply the PR and remove the custom fragment of POM, Maven will not attempt to recompile Guava shaded module once compiled sources are up to date. Note that no other module uses `maven-clean-plugin` to clean target directory before package phase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
